[webkit-reviews] review granted: [Bug 181638] [Attachment Support] Provide the `src` of an attachment to the UI delegate when an attachment is inserted : [Attachment 331314] Address assertions in WK1

[bugzilla-daemon at webkit.org]

mitz at webkit.org has granted Wenson Hsieh <wenson_hsieh at apple.com>'s request for
review:
Bug 181638: [Attachment Support] Provide the `src` of an attachment to the UI
delegate when an attachment is inserted
https://bugs.webkit.org/show_bug.cgi?id=181638

Attachment 331314: Address assertions in WK1

https://bugs.webkit.org/attachment.cgi?id=331314&action=review




--- Comment #8 from mitz at webkit.org ---
Comment on attachment 331314
  --> https://bugs.webkit.org/attachment.cgi?id=331314
Address assertions in WK1

View in context: https://bugs.webkit.org/attachment.cgi?id=331314&action=review

> Source/WebCore/editing/Editor.cpp:3783
> +	   // The document may have changed since the attachment element was
inserted, in which case we will suppress notifying the client of inserted
attachments.

Seems strange. And why don't we do the same with the removals?

> Source/WebCore/page/EditorClient.h:76
> +    virtual void didInsertAttachment(const String&, const String&) { }

Probably need to name these now.