[webkit-reviews] review granted: [Bug 181657] Support for preconnect Link headers : [Attachment 331355] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Yoav Weiss <yoav at yoav.ws>'s request
for review:
Bug 181657: Support for preconnect Link headers
https://bugs.webkit.org/show_bug.cgi?id=181657

Attachment 331355: Patch

https://bugs.webkit.org/attachment.cgi?id=331355&action=review




--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 331355
  --> https://bugs.webkit.org/attachment.cgi?id=331355
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=331355&action=review

> Source/WebCore/loader/LinkLoader.h:68
> +    static void preconnectIfNeeded(const LinkRelAttribute&, const URL& href,
Document&, const String& crossOrigin);
>      static std::unique_ptr<LinkPreloadResourceClient> preloadIfNeeded(const
LinkRelAttribute&, const URL& href, Document&, const String& as, const String&
media, const String& type, const String& crossOriginMode, LinkLoader*);

I probably would have omitted the "if needed" suffix from each of these
function names.