[webkit-reviews] review granted: [Bug 181647] [GStreamer] misc fixes and cleanups : [Attachment 331336] Patch

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at igalia.com> has granted Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 181647: [GStreamer] misc fixes and cleanups
https://bugs.webkit.org/show_bug.cgi?id=181647

Attachment 331336: Patch

https://bugs.webkit.org/attachment.cgi?id=331336&action=review




--- Comment #2 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 331336
  --> https://bugs.webkit.org/attachment.cgi?id=331336
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=331336&action=review

> Source/WebCore/ChangeLog:18
> +	   (WebCore::MediaPlayerPrivateGStreamer::handleMessage): Switch to
> +	   streaming code path when no content-length was reported by the
> +	   http source element.

Maybe this one is worth splitting into a separate patch?

> Source/WebCore/ChangeLog:31
> +	   (webkit_web_src_init): Enable keepAlive by default like in
souphttpsrc.

Ditto?

> Source/WebCore/ChangeLog:37
> +	   (CachedResourceStreamingClient::responseReceived): Change appsrc
> +	   stream-type when we wan't seek. Also update caps like souphttpsrc
> +	   does and emit headers as an element message, like souphttpsrc.

Ditto?

> Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:482
> +    GST_DEBUG_OBJECT(src, "Persistent connection support %s",
priv->keepAlive ? "enabled":"disabled");

Leave spaces around the :

> Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:799
> +    GST_DEBUG_OBJECT(src, "Size: %" G_GINT64_FORMAT ", seekable: %s",
priv->size, priv->seekable ? "yes":"no");

Ditto