[webkit-reviews] review granted: [Bug 180793] Web Inspector: Styles Redesign: properties should never be semitransparent or crossed out while editing : [Attachment 331296] Patch

[bugzilla-daemon at webkit.org]

Devin Rousso <webkit at devinrousso.com> has granted Nikita Vasilyev
<nvasilyev at apple.com>'s request for review:
Bug 180793: Web Inspector: Styles Redesign: properties should never be
semitransparent or crossed out while editing
https://bugs.webkit.org/show_bug.cgi?id=180793

Attachment 331296: Patch

https://bugs.webkit.org/attachment.cgi?id=331296&action=review




--- Comment #11 from Devin Rousso <webkit at devinrousso.com> ---
Comment on attachment 331296
  --> https://bugs.webkit.org/attachment.cgi?id=331296
Patch

r=me

One thing that I noticed when I was working on this was that when you edit the
value, it shifts the semicolon around.	This is because of the `margin-right:
3px;` in the `.spreadsheet-style-declaration-editor .value.editing` rule.  If
you remove that, the semicolon doesn't shift anymore, but it now appears
"above" the shadow.  I think the solution here is to move the editing element
"above" the rest of the content while it is being modified.

    .spreadsheet-style-declaration-editor .value.editing {
	display: inline-block;
	position: relative;
	z-index: 1;
    }