[webkit-reviews] review granted: [Bug 181627] [WebAuthN] Implement dummy WebAuthN IDLs : [Attachment 331277] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted Jiewen Tan
<jiewen_tan at apple.com>'s request for review:
Bug 181627: [WebAuthN] Implement dummy WebAuthN IDLs
https://bugs.webkit.org/show_bug.cgi?id=181627

Attachment 331277: Patch

https://bugs.webkit.org/attachment.cgi?id=331277&action=review




--- Comment #4 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 331277
  --> https://bugs.webkit.org/attachment.cgi?id=331277
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=331277&action=review

> Source/WebCore/Modules/webauthn/AuthenticatorAssertionResponse.h:37
> +    RefPtr<ArrayBuffer> authenticatorData();

I think these should just return a pointer.

> Source/WebCore/Modules/webauthn/AuthenticatorAssertionResponse.h:42
> +    RefPtr<ArrayBuffer> m_authenticatorData;

Can we not make any of these Ref's?

> Source/WebCore/Modules/webauthn/PublicKeyCredential.idl:28
> +// enum UserVerificationRequirement {

Can we add this later, rather than adding commented things?

> Source/WebCore/Modules/webauthn/PublicKeyCredentialCreationOptions.h:61
> +    unsigned long timeout;

Could we give these initializer lists to avoid uninitialized members?

> Source/WebCore/Modules/webauthn/PublicKeyCredentialCreationOptions.idl:31
> +// enum AttestationConveyancePreference {

ditto