[webkit-reviews] review granted: [Bug 181542] Replace all use of ConstExprPoisoned with Poisoned. : [Attachment 331281] patch for landing.

[bugzilla-daemon at webkit.org]

JF Bastien <jfbastien at apple.com> has granted  review:
Bug 181542: Replace all use of ConstExprPoisoned with Poisoned.
https://bugs.webkit.org/show_bug.cgi?id=181542

Attachment 331281: patch for landing.

https://bugs.webkit.org/attachment.cgi?id=331281&action=review




--- Comment #15 from JF Bastien <jfbastien at apple.com> ---
Comment on attachment 331281
  --> https://bugs.webkit.org/attachment.cgi?id=331281
patch for landing.

View in context: https://bugs.webkit.org/attachment.cgi?id=331281&action=review

All looks good. Question on relational operators can be addressed later.

> Source/WTF/wtf/Poisoned.h:133
> +    bool operator>=(T b) const { return unpoisoned() >= b; }

What I meant is that I'd drop these entirely, and only keep == and !=, unless
we actually use them. If we keep them, it may actually be better to compare the
poisoned values because that doesn't leak any info about the underlying data,
whereas comparing the underlying data definitely leaks it (albeit that's a
super unlikely source of info).