[webkit-reviews] review granted: [Bug 181603] ASSERTION FAILED: registration || isTerminating() in WebCore::SWServerWorker::skipWaiting() : [Attachment 331241] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 181603: ASSERTION FAILED: registration || isTerminating() in
WebCore::SWServerWorker::skipWaiting()
https://bugs.webkit.org/show_bug.cgi?id=181603

Attachment 331241: Patch

https://bugs.webkit.org/attachment.cgi?id=331241&action=review




--- Comment #6 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 331241
  --> https://bugs.webkit.org/attachment.cgi?id=331241
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=331241&action=review

> Source/WebCore/workers/service/server/SWServer.cpp:567
> +	   workerContextTerminated(worker);

Is this line needed?
Should we add an ASSERT(connection) as well before if (!connection)?

I would believe that if the connection is null, there probably was a connection
before and it was destroyed (broken IPC for instance).
In such a case, I would have expected that its destructor would clean/terminate
all its related workers.