[webkit-reviews] review denied: [Bug 181254] run-webkit-tests fails when there is a curly brace in Xcode build output : [Attachment 331238] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 12 15:27:24 PST 2018


Daniel Bates <dbates at webkit.org> has denied Jonathan Bedard
<jbedard at apple.com>'s request for review:
Bug 181254: run-webkit-tests fails when there is a curly brace in Xcode build
output
https://bugs.webkit.org/show_bug.cgi?id=181254

Attachment 331238: Patch

https://bugs.webkit.org/attachment.cgi?id=331238&action=review




--- Comment #17 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 331238
  --> https://bugs.webkit.org/attachment.cgi?id=331238
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=331238&action=review

> Tools/Scripts/webkitpy/port/base.py:1429
> +	   if decode_output:
> +	       output = output.decode('utf-8')

This does not make sense because |output| represents the decoded output when
decode_output is True. Please start reading from the last sentence of the first
paragraph in comment #13 again.


More information about the webkit-reviews mailing list