[webkit-reviews] review requested: [Bug 181599] PoisonedWriteBarrier : [Attachment 331219] patch

[bugzilla-daemon at webkit.org]

JF Bastien <jfbastien at apple.com> has asked  for review:
Bug 181599: PoisonedWriteBarrier
https://bugs.webkit.org/show_bug.cgi?id=181599

Attachment 331219: patch

https://bugs.webkit.org/attachment.cgi?id=331219&action=review




--- Comment #5 from JF Bastien <jfbastien at apple.com> ---
Created attachment 331219

  --> https://bugs.webkit.org/attachment.cgi?id=331219&action=review

patch

Address comments.

This should also fix the build (still going on my laptop...): code was
indirectly doing WriteBarrier<>.set() on JSGlobalObject with only a forward
declaration, so it didn't know that JSGlobalObject derives from JSCell. This is
now a compilation error because I static_cast to JSCell*, instead of
reinterpret_cast. This particular case was fine because the object layout
didn't change, but in general static_cast might require a base adjustment. It's
also good to check that there indeed is an inheritance hierarchy! I fixed the
issue by moving Structure.h's uses of .set() to its Inlines.h file.