[webkit-reviews] review denied: [Bug 181460] REGRESSION(r225650): The scores of MotionMark tests Multiply and Leaves dropped by 8% : [Attachment 331184] patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has denied Antti Koivisto
<koivisto at iki.fi>'s request for review:
Bug 181460: REGRESSION(r225650): The scores of MotionMark tests Multiply and
Leaves dropped by 8%
https://bugs.webkit.org/show_bug.cgi?id=181460

Attachment 331184: patch

https://bugs.webkit.org/attachment.cgi?id=331184&action=review




--- Comment #21 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 331184
  --> https://bugs.webkit.org/attachment.cgi?id=331184
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=331184&action=review

> Source/WebCore/ChangeLog:13
> +	   Don't do the expensive security origin test if the supplied sheet
base URL is null. This
> +	   is true for rules coming from the same document.

I think that this is still changing the behavior when the document can't make
requests to its own base URL (which is the case at least whenever there is a
<base> element with a different origin URL, or for unique origins).