[webkit-reviews] review granted: [Bug 181182] [JSC] NumberPrototype::extractRadixFromArgs incorrectly cast double to int32_t : [Attachment 331132] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Caio Lima <ticaiolima at gmail.com>'s
request for review:
Bug 181182: [JSC] NumberPrototype::extractRadixFromArgs incorrectly cast double
to int32_t
https://bugs.webkit.org/show_bug.cgi?id=181182

Attachment 331132: Patch

https://bugs.webkit.org/attachment.cgi?id=331132&action=review




--- Comment #13 from Darin Adler <darin at apple.com> ---
Comment on attachment 331132
  --> https://bugs.webkit.org/attachment.cgi?id=331132
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=331132&action=review

> Source/JavaScriptCore/runtime/NumberPrototype.cpp:628
> +	   return throwVMError(state, scope, createRangeError(state,
ASCIILiteral("toString() radix argument must be between 2 and 36")));

Using "else" we could share the two calls to throwVMError and createRangeError.