[webkit-reviews] review granted: [Bug 181522] [WebAuthN] Import a CBOR coder from Chromium : [Attachment 331146] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted Jiewen Tan
<jiewen_tan at apple.com>'s request for review:
Bug 181522: [WebAuthN] Import a CBOR coder from Chromium
https://bugs.webkit.org/show_bug.cgi?id=181522

Attachment 331146: Patch

https://bugs.webkit.org/attachment.cgi?id=331146&action=review




--- Comment #10 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 331146
  --> https://bugs.webkit.org/attachment.cgi?id=331146
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=331146&action=review

This version looks good. Please fix the 32-bit issues before you land.

> Source/WebCore/Modules/webauthn/cbor/CBORReader.cpp:35
> +#include <math.h>

<cmath>?