[webkit-reviews] review denied: [Bug 181570] REGRESSION(226788): AppStore Crashed @ JavaScriptCore: JSC::MacroAssemblerARM64::pushToSaveImmediateWithoutTouchingRegisters : [Attachment 331153] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jan 11 18:44:42 PST 2018
Keith Miller <keith_miller at apple.com> has denied Michael Saboff
<msaboff at apple.com>'s request for review:
Bug 181570: REGRESSION(226788): AppStore Crashed @ JavaScriptCore:
JSC::MacroAssemblerARM64::pushToSaveImmediateWithoutTouchingRegisters
https://bugs.webkit.org/show_bug.cgi?id=181570
Attachment 331153: Patch
https://bugs.webkit.org/attachment.cgi?id=331153&action=review
--- Comment #4 from Keith Miller <keith_miller at apple.com> ---
Comment on attachment 331153
--> https://bugs.webkit.org/attachment.cgi?id=331153
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=331153&action=review
> Source/JavaScriptCore/ChangeLog:10
> + Reverting these functions to use dataTempRegister and
memoryTempRegister as they may
> + be called from code that doesn't use cached registers. Added
comments in each case
> + why this is safe.
It seems like the actual fix is to make the callers of those functions set
m_allowScratchRegister = true.
More information about the webkit-reviews
mailing list