[webkit-reviews] review denied: [Bug 181466] Support MultiGetByOffset in the DFG : [Attachment 331097] patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has denied Saam Barati <sbarati at apple.com>'s
request for review:
Bug 181466: Support MultiGetByOffset in the DFG
https://bugs.webkit.org/show_bug.cgi?id=181466

Attachment 331097: patch

https://bugs.webkit.org/attachment.cgi?id=331097&action=review




--- Comment #11 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 331097
  --> https://bugs.webkit.org/attachment.cgi?id=331097
patch

Will revise this patch. Fil reminded me that we rely on profiling GetById in
the DFG when it's inlined to allow for each inlined site to have separate
profiling data (polyvariant inlining). We should probably only lower to
MultiGetByOffset if we're not inlined. Otherwise, it's probably important
enough to get that per-inlined-site data.

There's a chance this poly variant profiling doesn't actually matter in
practice, and perhaps the FTL has enough data to filter down the
MultiGetByOffset, but we might as well do the more conservative thing. And we
can re-evaluate the more aggressive thing later.