[webkit-reviews] review granted: [Bug 181538] webkitpy: Use partially disambiguated type in SimulatedDeviceManager._disambiguate_device_type : [Attachment 331059] Patch

[bugzilla-daemon at webkit.org]

Aakash Jain <aakash_jain at apple.com> has granted Jonathan Bedard
<jbedard at apple.com>'s request for review:
Bug 181538: webkitpy: Use partially disambiguated type in
SimulatedDeviceManager._disambiguate_device_type
https://bugs.webkit.org/show_bug.cgi?id=181538

Attachment 331059: Patch

https://bugs.webkit.org/attachment.cgi?id=331059&action=review




--- Comment #6 from Aakash Jain <aakash_jain at apple.com> ---
Comment on attachment 331059
  --> https://bugs.webkit.org/attachment.cgi?id=331059
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=331059&action=review

> Tools/Scripts/webkitpy/xcode/new_simulated_device.py:201
>	       software_variant=device_type.software_variant)

Add a comment here mentioning full_type is being copied from device_type.

> Tools/Scripts/webkitpy/xcode/new_simulated_device.py:203
> +	   runtime =
SimulatedDeviceManager.get_runtime_for_device_type(full_type)

Rename full_type to more readable like full_device_type.