[webkit-reviews] review granted: [Bug 181331] VoiceOver does not work when the WebContent process is using NSRunLoop. : [Attachment 331100] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted Per Arne Vollan
<pvollan at apple.com>'s request for review:
Bug 181331: VoiceOver does not work when the WebContent process is using
NSRunLoop.
https://bugs.webkit.org/show_bug.cgi?id=181331

Attachment 331100: Patch

https://bugs.webkit.org/attachment.cgi?id=331100&action=review




--- Comment #22 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 331100
  --> https://bugs.webkit.org/attachment.cgi?id=331100
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=331100&action=review

Assuming the statement about [NSApplication sharedApplication] I made is true,
r=me.

> Source/WebCore/PAL/ChangeLog:5
> +	   rdar://problem/36408004

<rdar://problem/3640004>

(I.e., angle brackets around the radar URL please!)

> Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:177
> +    [NSApplication sharedApplication];

So I believe that this call causes an alloc and init of NSApplication to occur.
Is that correct?