[webkit-reviews] review denied: [Bug 181522] [WebAuthN] Import a CBOR coder from Chromium : [Attachment 331035] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 11 08:43:42 PST 2018


Brent Fulgham <bfulgham at webkit.org> has denied Jiewen Tan
<jiewen_tan at apple.com>'s request for review:
Bug 181522: [WebAuthN] Import a CBOR coder from Chromium
https://bugs.webkit.org/show_bug.cgi?id=181522

Attachment 331035: Patch

https://bugs.webkit.org/attachment.cgi?id=331035&action=review




--- Comment #6 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 331035
  --> https://bugs.webkit.org/attachment.cgi?id=331035
Patch

I agree with Youenn about locating the sources in 'Source/ThirdParty/cbor'. I
think you told me that you were able to build this as a stand-alone binary, so
let's just make it a static library (like we do for libwebrtc). r- to make
those changes.


More information about the webkit-reviews mailing list