[webkit-reviews] review granted: [Bug 181423] Merge sync and async code paths for getting context menus : [Attachment 330794] Patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 181423: Merge sync and async code paths for getting context menus
https://bugs.webkit.org/show_bug.cgi?id=181423

Attachment 330794: Patch

https://bugs.webkit.org/attachment.cgi?id=330794&action=review




--- Comment #7 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 330794
  --> https://bugs.webkit.org/attachment.cgi?id=330794
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=330794&action=review

r=me

> Source/WebKit/UIProcess/API/glib/WebKitContextMenuClient.cpp:51
>	   webkitWebViewPopulateContextMenu(m_webView, menuItems,
hitTestResultData, variant.get());
> -	   return true;
> +	   contextMenuListener.useContextMenuItems({ });

So Glib does something special in `webkitWebViewPopulateContextMenu` instead of
passing the new items to `contextMenuListener.useContextMenuItems`? I'm
surprised this always passes an empty list to useContextMenuItems.

Edit: Oh I think I see, gtk/WebContextMenuProxyGtk.cpp calls this with a mostly
stub WebContextMenuListenerProxy, since
WebContextMenuProxyGtk::showContextMenuWithItems does nothing (and which you
just removed). I suppose it could be a real WebContextMenuListenerProxy that
does the webkitWebViewPopulateContextMenu call instead of happening here in the
client? Seems like it would amount to doing the same thing in the end.