[webkit-reviews] review granted: [Bug 180839] Web Inspector: Canvas tab: throttle recording slider updates : [Attachment 330960] Patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Matt Baker
<mattbaker at apple.com>'s request for review:
Bug 180839: Web Inspector: Canvas tab: throttle recording slider updates
https://bugs.webkit.org/show_bug.cgi?id=180839

Attachment 330960: Patch

https://bugs.webkit.org/attachment.cgi?id=330960&action=review




--- Comment #19 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 330960
  --> https://bugs.webkit.org/attachment.cgi?id=330960
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=330960&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/RecordingContentView.js:-122
> -    // Protected

Aren't shown/hidden protected though?

> LayoutTests/inspector/unit-tests/throttle.html:110
> +	       let throttleProxy = object.throttle(delay);

I feel like this should be slightly less than the delay, like 20, in order to
further prove that the throttle didn't fire after the verification timeout of
50ms.