[webkit-reviews] review granted: [Bug 181469] Add nullptr_t specialization of poison : [Attachment 330953] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 10 13:16:06 PST 2018


JF Bastien <jfbastien at apple.com> has granted Don Olmstead
<don.olmstead at sony.com>'s request for review:
Bug 181469: Add nullptr_t specialization of poison
https://bugs.webkit.org/show_bug.cgi?id=181469

Attachment 330953: Patch

https://bugs.webkit.org/attachment.cgi?id=330953&action=review




--- Comment #22 from JF Bastien <jfbastien at apple.com> ---
Comment on attachment 330953
  --> https://bugs.webkit.org/attachment.cgi?id=330953
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=330953&action=review

r=me

>> Source/WTF/wtf/Poisoned.h:202
>> +	constexpr static PoisonedBits poison(std::nullptr_t) { return 0; }
> 
> Its outside the #if ENABLE(POISON) so its in the common implementation

Ha! I totally missed this, sorry.


More information about the webkit-reviews mailing list