[webkit-reviews] review denied: [Bug 181469] Add nullptr_t specialization of poison : [Attachment 330950] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 10 13:00:40 PST 2018


JF Bastien <jfbastien at apple.com> has denied  review:
Bug 181469: Add nullptr_t specialization of poison
https://bugs.webkit.org/show_bug.cgi?id=181469

Attachment 330950: Patch

https://bugs.webkit.org/attachment.cgi?id=330950&action=review




--- Comment #18 from JF Bastien <jfbastien at apple.com> ---
Comment on attachment 330950
  --> https://bugs.webkit.org/attachment.cgi?id=330950
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=330950&action=review

> Source/WTF/wtf/Poisoned.h:203
> +    constexpr static PoisonedBits poison(std::nullptr_t) { return 0; }

You also need this specialization for the #else clause because bitwise_cast of
nullptr_t isn't guaranteed to give 0 in C++.


More information about the webkit-reviews mailing list