[webkit-reviews] review requested: [Bug 181483] Poison small JSObject derivatives which only contain pointers : [Attachment 330932] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 10 11:08:45 PST 2018


JF Bastien <jfbastien at apple.com> has asked  for review:
Bug 181483: Poison small JSObject derivatives which only contain pointers
https://bugs.webkit.org/show_bug.cgi?id=181483

Attachment 330932: patch

https://bugs.webkit.org/attachment.cgi?id=330932&action=review




--- Comment #10 from JF Bastien <jfbastien at apple.com> ---
Created attachment 330932

  --> https://bugs.webkit.org/attachment.cgi?id=330932&action=review

patch

MSVC fails the build because the `using JSGlobalObject::PoisonedUniquePtr =
...` re-declaration shadows the new usage in JSCallbackObject. Qualify that new
one with WTF:: to disambiguate.


More information about the webkit-reviews mailing list