[webkit-reviews] review granted: [Bug 181484] REGRESSION (r226715): don't re-check number of simulators in child processes : [Attachment 330916] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 10 10:56:33 PST 2018


Aakash Jain <aakash_jain at apple.com> has granted Jonathan Bedard
<jbedard at apple.com>'s request for review:
Bug 181484: REGRESSION (r226715): don't re-check number of simulators in child
processes
https://bugs.webkit.org/show_bug.cgi?id=181484

Attachment 330916: Patch

https://bugs.webkit.org/attachment.cgi?id=330916&action=review




--- Comment #3 from Aakash Jain <aakash_jain at apple.com> ---
Comment on attachment 330916
  --> https://bugs.webkit.org/attachment.cgi?id=330916
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=330916&action=review

> Tools/Scripts/webkitpy/port/ios_simulator.py:53
> +	   if not SimulatedDeviceManager.INITIALIZED_DEVICES and
self.get_option('child_processes', self.default_child_processes()) >
SimulatedDeviceManager.max_supported_simulators(self.host):

Just for future reference, max_supported_simulators seems like a misleading
name, it should be something like current_num_supported_simulators. We wouldn't
had this issue if max_supported_simulators always return the same value
(maximum number of simulators supported by the machine).


More information about the webkit-reviews mailing list