[webkit-reviews] review granted: [Bug 181473] WebDriver: deserializeTimeouts() shouldn't reject double timeout values : [Attachment 330902] Patch

[bugzilla-daemon at webkit.org]

Carlos Garcia Campos <cgarcia at igalia.com> has granted Zan Dobersek
<zan at falconsigh.net>'s request for review:
Bug 181473: WebDriver: deserializeTimeouts() shouldn't reject double timeout
values
https://bugs.webkit.org/show_bug.cgi?id=181473

Attachment 330902: Patch

https://bugs.webkit.org/attachment.cgi?id=330902&action=review




--- Comment #5 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 330902
  --> https://bugs.webkit.org/attachment.cgi?id=330902
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=330902&action=review

Excellent, thanks!

> Source/WebDriver/ChangeLog:7
> +

Please, mention here the tests fixed.

> Source/WebDriver/WebDriverService.cpp:280
> +    // value, i.e. if the double value was not originally in integer form.

Add also a link to the spec
https://w3c.github.io/webdriver/webdriver-spec.html#dfn-integer