[webkit-reviews] review granted: [Bug 181474] WebDriver: run-webdriver-tests doesn't handle test names with a '/' correctly : [Attachment 330892] Patch

[bugzilla-daemon at webkit.org]

Carlos Alberto Lopez Perez <clopez at igalia.com> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 181474: WebDriver: run-webdriver-tests doesn't handle test names with a '/'
correctly
https://bugs.webkit.org/show_bug.cgi?id=181474

Attachment 330892: Patch

https://bugs.webkit.org/attachment.cgi?id=330892&action=review




--- Comment #3 from Carlos Alberto Lopez Perez <clopez at igalia.com> ---
Comment on attachment 330892
  --> https://bugs.webkit.org/attachment.cgi?id=330892
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=330892&action=review

>> Tools/Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:82
>> +	def _subtest_name(self, subtest):
> 
> Looks like this could be a free function, self isn't referenced in the body.

I think its ok to have it as part of the object if it is related to it.