[webkit-reviews] review granted: [Bug 181446] Make service workers behave correctly with regards to Page Cache : [Attachment 330843] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 181446: Make service workers behave correctly with regards to Page Cache
https://bugs.webkit.org/show_bug.cgi?id=181446

Attachment 330843: Patch

https://bugs.webkit.org/attachment.cgi?id=330843&action=review




--- Comment #3 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 330843
  --> https://bugs.webkit.org/attachment.cgi?id=330843
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=330843&action=review

> Source/WebCore/dom/Document.cpp:4919
> +	   ASSERT_WITH_MESSAGE(!activeServiceWorker(), "Documents with an
active service worker should not go into PageCache in the first place");

Maybe the message should be made specific here?