[webkit-reviews] review granted: [Bug 180555] webkitpy: Refactor simulator code : [Attachment 330840] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 9 16:09:00 PST 2018


Aakash Jain <aakash_jain at apple.com> has granted Jonathan Bedard
<jbedard at apple.com>'s request for review:
Bug 180555: webkitpy: Refactor simulator code
https://bugs.webkit.org/show_bug.cgi?id=180555

Attachment 330840: Patch

https://bugs.webkit.org/attachment.cgi?id=330840&action=review




--- Comment #39 from Aakash Jain <aakash_jain at apple.com> ---
Comment on attachment 330840
  --> https://bugs.webkit.org/attachment.cgi?id=330840
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=330840&action=review

Please make sure to keep an eye on the bots after this land.

> Tools/Scripts/webkitpy/port/ios_simulator.py:81
> +	   return num_booted_sims

As discussed this code can be reorganized to be more readable/clear.


More information about the webkit-reviews mailing list