[webkit-reviews] review granted: [Bug 181451] [RenderTreeBuilder] Move RenderElement addChild mutation logic to RenderTreeBuilder : [Attachment 330848] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted zalan <zalan at apple.com>'s request
for review:
Bug 181451: [RenderTreeBuilder] Move RenderElement addChild mutation logic to
RenderTreeBuilder
https://bugs.webkit.org/show_bug.cgi?id=181451

Attachment 330848: Patch

https://bugs.webkit.org/attachment.cgi?id=330848&action=review




--- Comment #3 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 330848
  --> https://bugs.webkit.org/attachment.cgi?id=330848
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=330848&action=review

> Source/WebCore/rendering/updating/RenderTreeBuilder.cpp:227
> +bool RenderTreeBuilder::childRequiresTable(const RenderElement& parent,
const RenderObject& child)

Maybe this should go to the Table helper? You wouldn't need to add all those
includes either.