[webkit-reviews] review granted: [Bug 181450] [Web Animations] Expose the id property on Animation : [Attachment 330846] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jan 9 13:11:48 PST 2018
Dean Jackson <dino at apple.com> has granted Antoine Quint <graouts at apple.com>'s
request for review:
Bug 181450: [Web Animations] Expose the id property on Animation
https://bugs.webkit.org/show_bug.cgi?id=181450
Attachment 330846: Patch
https://bugs.webkit.org/attachment.cgi?id=330846&action=review
--- Comment #3 from Dean Jackson <dino at apple.com> ---
Comment on attachment 330846
--> https://bugs.webkit.org/attachment.cgi?id=330846
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=330846&action=review
> Source/WebCore/animation/WebAnimation.h:53
> + const AtomicString& id() const { return m_id; }
> + void setId(const AtomicString& id) { m_id = id; }
Why not String?
More information about the webkit-reviews
mailing list