[webkit-reviews] review granted: [Bug 181409] Reduce graph size by replacing terminal nodes in blocks that have a ForceOSRExit with Unreachable : [Attachment 330785] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 9 12:38:01 PST 2018


Keith Miller <keith_miller at apple.com> has granted Saam Barati
<sbarati at apple.com>'s request for review:
Bug 181409: Reduce graph size by replacing terminal nodes in blocks that have a
ForceOSRExit with Unreachable
https://bugs.webkit.org/show_bug.cgi?id=181409

Attachment 330785: patch

https://bugs.webkit.org/attachment.cgi?id=330785&action=review




--- Comment #7 from Keith Miller <keith_miller at apple.com> ---
Comment on attachment 330785
  --> https://bugs.webkit.org/attachment.cgi?id=330785
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=330785&action=review

r=me.

> Source/JavaScriptCore/ChangeLog:27
> +	   it, we could use additional inputs into this mechanism. For example,
we could
> +	   profile if a basic block ever executes inside the LLInt/Baseline,
and
> +	   remove parts of the CFG based on that.

File a bug?


More information about the webkit-reviews mailing list