[webkit-reviews] review granted: [Bug 180827] [webkitpy] PlatformInfo should have default argument for casual use : [Attachment 329499] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 9 11:09:31 PST 2018


David Kilzer (:ddkilzer) <ddkilzer at webkit.org> has granted Basuke Suzuki
<Basuke.Suzuki at sony.com>'s request for review:
Bug 180827: [webkitpy] PlatformInfo should have default argument for casual use
https://bugs.webkit.org/show_bug.cgi?id=180827

Attachment 329499: patch

https://bugs.webkit.org/attachment.cgi?id=329499&action=review




--- Comment #9 from David Kilzer (:ddkilzer) <ddkilzer at webkit.org> ---
Comment on attachment 329499
  --> https://bugs.webkit.org/attachment.cgi?id=329499
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=329499&action=review

r=me

> Tools/ChangeLog:14
> +	   Currently to instanciate PlatformInfo, it requires arguments, which
is usually
> +	   sys, platform and Executive(). They are straight forward and should
be handled
> +	   by default arguments. Then we can instanciate PlatformInfo more
casual.

Typo × 2:  instanciate => instantiate


More information about the webkit-reviews mailing list