[webkit-reviews] review denied: [Bug 180555] webkitpy: Refactor simulator code : [Attachment 330758] Patch

[bugzilla-daemon at webkit.org]

Aakash Jain <aakash_jain at apple.com> has denied Jonathan Bedard
<jbedard at apple.com>'s request for review:
Bug 180555: webkitpy: Refactor simulator code
https://bugs.webkit.org/show_bug.cgi?id=180555

Attachment 330758: Patch

https://bugs.webkit.org/attachment.cgi?id=330758&action=review




--- Comment #34 from Aakash Jain <aakash_jain at apple.com> ---
Comment on attachment 330758
  --> https://bugs.webkit.org/attachment.cgi?id=330758
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=330758&action=review

> Tools/Scripts/webkitpy/port/ios_simulator.py:63
> +	       number_of_simulators_to_use = self.get_option('child_processes',
self.default_child_processes())

This logic to determine number_of_simulators_to_use seems unnecessarily
complicated. You can consider initializing number_of_simulators_to_use with
self.get_option('child_processes', self.default_child_processes())

> Tools/Scripts/webkitpy/port/ios_simulator.py:66
> +	       _log.warn('The specified number of child processes is greater
than the number of Simulators to be used. Setting child_processes to
{}.'.format(number_of_simulators_to_use))

This doesn't happen while using dedicated simulator. We will incorrectly print
this statement, while still using higher number of simulators.

Also this print statement should be accompanied with the corresponding
assignment.