[webkit-reviews] review granted: [Bug 181387] [FreeType] Use FastMalloc for FreeType : [Attachment 330824] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jan 9 08:16:38 PST 2018
Michael Catanzaro <mcatanzaro at igalia.com> has granted Yusuke Suzuki
<utatane.tea at gmail.com>'s request for review:
Bug 181387: [FreeType] Use FastMalloc for FreeType
https://bugs.webkit.org/show_bug.cgi?id=181387
Attachment 330824: Patch
https://bugs.webkit.org/attachment.cgi?id=330824&action=review
--- Comment #7 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 330824
--> https://bugs.webkit.org/attachment.cgi?id=330824
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=330824&action=review
>
Source/WebCore/platform/graphics/freetype/FontCustomPlatformDataFreeType.cpp:81
> + UNUSED_PARAM(currentSize);
Better style would be to just not name the parameter IMO. You already left
links to the documentation, so people can look it up if they want to know what
it is.
More information about the webkit-reviews
mailing list