[webkit-reviews] review granted: [Bug 180928] [EME] Add layout test for clearKey CENC message event : [Attachment 330805] Patch

[bugzilla-daemon at webkit.org]

Xabier Rodríguez Calvar <calvaris at igalia.com> has granted Yacine Bandou
<bandou.yacine at gmail.com>'s request for review:
Bug 180928: [EME] Add layout test for clearKey CENC message event
https://bugs.webkit.org/show_bug.cgi?id=180928

Attachment 330805: Patch

https://bugs.webkit.org/attachment.cgi?id=330805&action=review




--- Comment #5 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Comment on attachment 330805
  --> https://bugs.webkit.org/attachment.cgi?id=330805
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=330805&action=review

Most important part is removing the [ Pass ] from the WPE expectations.

Now, I'd encourage you to use more const and let instead of var. I see you have
converted many var into let but some of them can be const and there are some
var left.

> LayoutTests/platform/wpe/TestExpectations:1003
> +media/encrypted-media/clearKey/clearKey-message-cenc-event.html [ Pass ]
> +media/encrypted-media/clearKey/clearKey-message-cenc-event-mse.html [ Pass ]
> +

This is not needed since we are not skipping globally.