[webkit-reviews] review granted: [Bug 181413] Make ObjC SPI equivalent to WKPageNavigationClient.decidePolicyForPluginLoad : [Attachment 330751] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jan 8 19:15:56 PST 2018
Wenson Hsieh <wenson_hsieh at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 181413: Make ObjC SPI equivalent to
WKPageNavigationClient.decidePolicyForPluginLoad
https://bugs.webkit.org/show_bug.cgi?id=181413
Attachment 330751: Patch
https://bugs.webkit.org/attachment.cgi?id=330751&action=review
--- Comment #2 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 330751
--> https://bugs.webkit.org/attachment.cgi?id=330751
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=330751&action=review
> Source/WebKit/UIProcess/Cocoa/NavigationState.mm:316
> +static WebKit::PluginModuleLoadPolicy
toPluginModuleLoadPolicy(_WKPluginModuleLoadPolicy policy)
Nit - I think https://webkit.org/code-style-guidelines/#names-verb recommends
against prefixing with "to".
More information about the webkit-reviews
mailing list