[webkit-reviews] review granted: [Bug 181405] [RenderTreeBuilder] Move SVG addChild logic to RenderTreeBuilder : [Attachment 330738] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 8 14:47:35 PST 2018


Antti Koivisto <koivisto at iki.fi> has granted zalan <zalan at apple.com>'s request
for review:
Bug 181405: [RenderTreeBuilder] Move SVG addChild logic to RenderTreeBuilder
https://bugs.webkit.org/show_bug.cgi?id=181405

Attachment 330738: Patch

https://bugs.webkit.org/attachment.cgi?id=330738&action=review




--- Comment #3 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 330738
  --> https://bugs.webkit.org/attachment.cgi?id=330738
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=330738&action=review

> Source/WebCore/rendering/updating/RenderTreeBuilder.h:89
> +    SVG& SVGBuilder() { return *m_SVGBuilder; }

I think it is svgBuilder() and m_svgBuilder by our naming conventions.


More information about the webkit-reviews mailing list