[webkit-reviews] review granted: [Bug 180081] [EME] Add the CENC initData support in ClearKey CDM : [Attachment 330125] Patch

[bugzilla-daemon at webkit.org]

Xabier Rodríguez Calvar <calvaris at igalia.com> has granted Yacine Bandou
<bandou.yacine at gmail.com>'s request for review:
Bug 180081: [EME] Add the CENC initData support in ClearKey CDM
https://bugs.webkit.org/show_bug.cgi?id=180081

Attachment 330125: Patch

https://bugs.webkit.org/attachment.cgi?id=330125&action=review




--- Comment #9 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Comment on attachment 330125
  --> https://bugs.webkit.org/attachment.cgi?id=330125
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=330125&action=review

> Source/WebCore/platform/encryptedmedia/clearkey/CDMClearKey.cpp:172
> +    if (initData.isEmpty() ||  initData.size() >
std::numeric_limits<unsigned>::max())

(In reply to Xabier Rodríguez Calvar from comment #7)
> > Source/WebCore/platform/encryptedmedia/clearkey/CDMClearKey.cpp:172
> > +	 if (initData.isEmpty() ||  initData.size() >
std::numeric_limits<unsigned>::max())
> 
> There are two spaces before initData.size().

Not addressed.