[webkit-reviews] review denied: [Bug 181334] Web Inspector: Script parse errors point to "(anonymous function)" in console : [Attachment 330604] [PATCH] For Bots 1

[bugzilla-daemon at webkit.org]

Brian Burg <bburg at apple.com> has denied Joseph Pecoraro <joepeck at webkit.org>'s
request for review:
Bug 181334: Web Inspector: Script parse errors point to "(anonymous function)"
in console
https://bugs.webkit.org/show_bug.cgi?id=181334

Attachment 330604: [PATCH] For Bots 1

https://bugs.webkit.org/attachment.cgi?id=330604&action=review




--- Comment #12 from Brian Burg <bburg at apple.com> ---
Comment on attachment 330604
  --> https://bugs.webkit.org/attachment.cgi?id=330604
[PATCH] For Bots 1

View in context: https://bugs.webkit.org/attachment.cgi?id=330604&action=review

r- pending questions and green bots

> Source/JavaScriptCore/ChangeLog:13
> +	   Simplify creating a call stack from an exception. Eliminate edge
cases.

Without explicit coverage for these cases in the test suite it's unclear what
the impact of this is. Instead there are some mysterious rebaselines in other
tests, which don't always make sense (s/undefined/???/ seems even less useful).
Shouldn't it be able to print (global), (eval) or the actual HTML source name
in those rebaselines?