[webkit-reviews] review granted: [Bug 181115] REGRESSION(r224460): Text fields sometimes get "messed up" : [Attachment 330671] Patch

[bugzilla-daemon at webkit.org]

zalan <zalan at apple.com> has granted Carlos Garcia Campos <cgarcia at igalia.com>'s
request for review:
Bug 181115: REGRESSION(r224460): Text fields sometimes get "messed up"
https://bugs.webkit.org/show_bug.cgi?id=181115

Attachment 330671: Patch

https://bugs.webkit.org/attachment.cgi?id=330671&action=review




--- Comment #13 from zalan <zalan at apple.com> ---
Comment on attachment 330671
  --> https://bugs.webkit.org/attachment.cgi?id=330671
Patch

I think having paintOffsetForClipRect = m_paintOffset +
renderer.scrollPosition(); is more correct/explicit than what we had pre
r224460. Also, with this patch, computeOffsets() does not actually computes all
the offsets and could lead to incorrect assumptions in the future.