[webkit-reviews] review granted: [Bug 181380] [Cairo] Contain shadow blur requirement state in a separate object : [Attachment 330675] Patch

[bugzilla-daemon at webkit.org]

Carlos Garcia Campos <cgarcia at igalia.com> has granted Zan Dobersek
<zan at falconsigh.net>'s request for review:
Bug 181380: [Cairo] Contain shadow blur requirement state in a separate object
https://bugs.webkit.org/show_bug.cgi?id=181380

Attachment 330675: Patch

https://bugs.webkit.org/attachment.cgi?id=330675&action=review




--- Comment #3 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 330675
  --> https://bugs.webkit.org/attachment.cgi?id=330675
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=330675&action=review

> Source/WebCore/platform/graphics/cairo/CairoOperations.h:81
> +    ShadowBlurUsage() = default;

Why is this needed?

> Source/WebCore/platform/graphics/cairo/CairoOperations.h:88
> +    float shadowBlur;
> +    bool shadowsIgnoreTransforms;

These are uninitialized when the default ctor is used.