[webkit-reviews] review granted: [Bug 181287] Implement createImageBitmap(ImageBitmap) : [Attachment 330460] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Ms2ger <Ms2ger at igalia.com>'s request
for review:
Bug 181287: Implement createImageBitmap(ImageBitmap)
https://bugs.webkit.org/show_bug.cgi?id=181287

Attachment 330460: Patch

https://bugs.webkit.org/attachment.cgi?id=330460&action=review




--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 330460
  --> https://bugs.webkit.org/attachment.cgi?id=330460
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=330460&action=review

> Source/WebCore/html/ImageBitmap.cpp:399
> +    if (existingImageBitmap->isDetached() || !existingImageBitmap->buffer())
{

Why do we need both checks? Why isn’t isDetached sufficient? Do we have test
cases covering both cases?