[webkit-reviews] review granted: [Bug 181350] Add ability to disable indexed property masking for testing : [Attachment 330599] Patch

[bugzilla-daemon at webkit.org]

Keith Miller <keith_miller at apple.com> has granted Michael Saboff
<msaboff at apple.com>'s request for review:
Bug 181350: Add ability to disable indexed property masking for testing
https://bugs.webkit.org/show_bug.cgi?id=181350

Attachment 330599: Patch

https://bugs.webkit.org/attachment.cgi?id=330599&action=review




--- Comment #3 from Keith Miller <keith_miller at apple.com> ---
Comment on attachment 330599
  --> https://bugs.webkit.org/attachment.cgi?id=330599
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=330599&action=review

r=me with a nit.

> Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp:13159
> +	   if (m_indexMaskingMode == IndexMaskingEnabled) {
> +	       LValue mask = m_out.load32(base,
m_heaps.JSObject_butterflyMask);
> +	       offset = m_out.shl(m_out.zeroExtPtr(m_out.bitAnd(mask, index)),
m_out.constIntPtr(logElementSize(type)));
> +	   } else
> +	       offset = m_out.shl(m_out.zeroExtPtr(index),
m_out.constIntPtr(logElementSize(type)));

I think you can just make this.

if (m_indexMaskingMode == IndexMaskingEnabled)
    index = m_out.bitAnd(index, m_out.load32(base,
m_heaps.JSObject_butterflyMask));
LValue offset = m_out.shl(m_out.zeroExtPtr(index),
m_out.constIntPtr(logElementSize(type)));