[webkit-reviews] review granted: [Bug 181331] VoiceOver does not work when the WebContent process is using NSRunLoop. : [Attachment 330558] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted Per Arne Vollan
<pvollan at apple.com>'s request for review:
Bug 181331: VoiceOver does not work when the WebContent process is using
NSRunLoop.
https://bugs.webkit.org/show_bug.cgi?id=181331

Attachment 330558: Patch

https://bugs.webkit.org/attachment.cgi?id=330558&action=review




--- Comment #2 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 330558
  --> https://bugs.webkit.org/attachment.cgi?id=330558
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=330558&action=review

This looks good, but I'm sad we have to instantiate an NSApp instance. We
should see if the accessibility team can live without that change (but that's
not relevant to this patch).

> Source/WebKit/Configurations/WebContentService.xcconfig:56
> +RUNLOOP_TYPE[sdk=macosx10.11*] = _NSApplicationMain;

Oh, nice!

> Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:302
> +    NSApp = [NSApplication alloc];

We need to see if allocating an NSApplication causes us to attach to stuff we
don't want. So the accessibility code needs an NSApp instantiated to work? Or
is this just something that they could potentially fix on their side?