[webkit-reviews] review granted: [Bug 181316] SVGAnimatedListPropertyTearOff::synchronizeWrappersIfNeeded() should do nothing if the property is not animating : [Attachment 330556] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Said Abou-Hallawa
<sabouhallawa at apple.com>'s request for review:
Bug 181316: SVGAnimatedListPropertyTearOff::synchronizeWrappersIfNeeded()
should do nothing if the property is not animating
https://bugs.webkit.org/show_bug.cgi?id=181316

Attachment 330556: Patch

https://bugs.webkit.org/attachment.cgi?id=330556&action=review




--- Comment #4 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 330556
  --> https://bugs.webkit.org/attachment.cgi?id=330556
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=330556&action=review

> Source/WebCore/ChangeLog:9
> +	   This is a speculative change to fix a crash which appeared after
r226065.

This should say why there is no testcase.

> Source/WebCore/svg/properties/SVGAnimatedListPropertyTearOff.h:147
>	   ASSERT(isAnimating());
> +	   if (!isAnimating())

We normally avoid patterns like this. If you think the assert and the if() are
both needed, then add a comment saying "this should never happen, but we've
seen it in the field. Please comment in bug ### i you hit this" or something.