[webkit-reviews] review granted: [Bug 181319] [RenderTreeBuilder] Move RenderBlock addChild logic to RenderTreeBuilder : [Attachment 330532] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted zalan <zalan at apple.com>'s request
for review:
Bug 181319: [RenderTreeBuilder] Move RenderBlock addChild logic to
RenderTreeBuilder
https://bugs.webkit.org/show_bug.cgi?id=181319

Attachment 330532: Patch

https://bugs.webkit.org/attachment.cgi?id=330532&action=review




--- Comment #6 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 330532
  --> https://bugs.webkit.org/attachment.cgi?id=330532
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=330532&action=review

> Source/WebCore/rendering/RenderBlock.cpp:2980
> -    makeChildrenNonInline();
> +    RenderTreeBuilder::makeChildrenNonInline(*this);

For consistency and future I think these should be non-static members of
RenderTreeBuilder. You can use RenderTreeBuilder::current() to get the instance
for now.

> Source/WebCore/rendering/updating/RenderTreeBuilder.h:53
> +    static void makeChildrenNonInline(RenderBlock& parent, RenderObject*
insertionPoint = nullptr);
> +    static RenderObject* splitAnonymousBoxesAroundChild(RenderBox& parent,
RenderObject* beforeChild);

For consistency and future I think these should be non-static members of
RenderTreeBuilder. You can use RenderTreeBuilder::current() to get the instance
without having to pass it around.