[webkit-reviews] review granted: [Bug 180770] Web Inspector: replace HTMLCanvasElement with CanvasRenderingContext for instrumentation logic : [Attachment 330506] Patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Devin Rousso
<webkit at devinrousso.com>'s request for review:
Bug 180770: Web Inspector: replace HTMLCanvasElement with
CanvasRenderingContext for instrumentation logic
https://bugs.webkit.org/show_bug.cgi?id=180770

Attachment 330506: Patch

https://bugs.webkit.org/attachment.cgi?id=330506&action=review




--- Comment #84 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 330506
  --> https://bugs.webkit.org/attachment.cgi?id=330506
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=330506&action=review

r=me

> Source/WebCore/html/CanvasBase.h:63
> +    void addObserver(CanvasObserver&);
> +    void removeObserver(CanvasObserver&);

Style: I'd put these after the list of virtual methods instead of in the
middle. And maybe the notifyObserver functions could be made protected instead
of public, but public is fine.