[webkit-reviews] review granted: [Bug 181291] [MediaStream] Add Mock screen capture source : [Attachment 330474] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jan 4 11:48:31 PST 2018
Dean Jackson <dino at apple.com> has granted Eric Carlson
<eric.carlson at apple.com>'s request for review:
Bug 181291: [MediaStream] Add Mock screen capture source
https://bugs.webkit.org/show_bug.cgi?id=181291
Attachment 330474: Patch
https://bugs.webkit.org/attachment.cgi?id=330474&action=review
--- Comment #3 from Dean Jackson <dino at apple.com> ---
Comment on attachment 330474
--> https://bugs.webkit.org/attachment.cgi?id=330474
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=330474&action=review
> Source/WebCore/platform/mediastream/mac/DisplayCaptureSourceCocoa.h:74
> + double m_startTime { NAN };
> + double m_elapsedTime { 0 };
Should you use Seconds here, rather than a double?
More information about the webkit-reviews
mailing list