[webkit-reviews] review granted: [Bug 181265] Add "noInline" to $vm : [Attachment 330420] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jan 3 16:31:42 PST 2018
Mark Lam <mark.lam at apple.com> has granted Michael Saboff <msaboff at apple.com>'s
request for review:
Bug 181265: Add "noInline" to $vm
https://bugs.webkit.org/show_bug.cgi?id=181265
Attachment 330420: Patch
https://bugs.webkit.org/attachment.cgi?id=330420&action=review
--- Comment #4 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 330420
--> https://bugs.webkit.org/attachment.cgi?id=330420
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=330420&action=review
r=me with style fix.
> Source/JavaScriptCore/tools/JSDollarVM.cpp:1175
> + FunctionExecutable* executable = jsDynamicCast<FunctionExecutable*>(vm,
> +
theFunction->executable());
> + return executable;
Please fix style issue on line 1174. Maybe just put this in one line:
return jsDynamicCast<FunctionExecutable*>(vm, theFunction->executable());
More information about the webkit-reviews
mailing list