[webkit-reviews] review granted: [Bug 181192] [Attachment Support] Create attachment elements when dropping files on iOS : [Attachment 330307] v2 with slight tweaks

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 181192: [Attachment Support] Create attachment elements when dropping files
on iOS
https://bugs.webkit.org/show_bug.cgi?id=181192

Attachment 330307: v2 with slight tweaks

https://bugs.webkit.org/attachment.cgi?id=330307&action=review




--- Comment #4 from Tim Horton <thorton at apple.com> ---
Comment on attachment 330307
  --> https://bugs.webkit.org/attachment.cgi?id=330307
v2 with slight tweaks

View in context: https://bugs.webkit.org/attachment.cgi?id=330307&action=review

> Source/WebCore/editing/WebContentReader.cpp:34
> +void WebContentReader::ensureFragment()

I feel like ensure functions usually return the thing they’re ensuring.

> Source/WebCore/platform/PasteboardItemInfo.h:37
> +    bool prefersAttachmentPresentation;
> +    bool prefersInlinePresentation;

Both as separate bits? Seems a bit weird, what if you set both? Should be an
enum, no?

> Source/WebKit/Scripts/webkit/messages.py:379
> +	   'WebCore::PasteboardItemInfo': ['<WebCore/PasteboardItemInfo.h>'],

You shouldn’t have to add this.