[webkit-reviews] review granted: [Bug 181067] Service Worker should expose redirect mode for navigation loads as manual : [Attachment 330373] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jan 3 12:35:37 PST 2018
Alex Christensen <achristensen at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 181067: Service Worker should expose redirect mode for navigation loads as
manual
https://bugs.webkit.org/show_bug.cgi?id=181067
Attachment 330373: Patch
https://bugs.webkit.org/attachment.cgi?id=330373&action=review
--- Comment #9 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 330373
--> https://bugs.webkit.org/attachment.cgi?id=330373
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=330373&action=review
> Source/WebCore/loader/CrossOriginAccessControl.cpp:139
> + if (!headersToKeep.contains(HTTPHeaderName::ContentType)) {
> + if (!isCrossOriginSafeRequestHeader(HTTPHeaderName::ContentType,
request.httpContentType()))
You could just use && here
> Source/WebKit/WebProcess/Storage/ServiceWorkerClientFetch.cpp:90
> + if ((options.redirect != FetchOptions::Redirect::Manual && options.mode
!= FetchOptions::Mode::Navigate) && response.tainting() ==
ResourceResponse::Tainting::Opaqueredirect)
This has unnecessary parentheses.
More information about the webkit-reviews
mailing list